[Blazor] Avoid defining webassembly.js as a framework asset #59965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
javiercn
force-pushed
the
javiercn/framework-assets-fix
branch
from
ea34936 to
be04b5d
Compare
javiercn
force-pushed
the
javiercn/framework-assets-fix
branch
from
95b8ba9 to
d1dad38
Compare
javiercn
commented
Jan 21, 2025
| @@ -1,3 +1,11 @@ | |||
| <Project> | |||
| <PropertyGroup Condition="'$(UsingMicrosoftNETSdkBlazorWebAssembly)' == 'true' and '$(BuildNodeJS)' != 'false'"> | |||
There was a problem hiding this comment.
BuildNodeJs is `` in some cases, so this check needs to explicitly check against false
lewing
approved these changes
Jan 21, 2025
captainsafia
pushed a commit
that referenced
this pull request
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.Internal.Assetspackage areblazor.web.jsandblazor.server.js.blazor.webassembly.jsshould continue shipping as a package.We should look into making
blazor.webassembly.jsa regular static web asset, instead of the custom dance that happens now.This change is in reaction to an issue we are seeing in a dependency update PR where blazor.webassembly.js is getting included twice.
Once by
_ResolveBlazorFrameworkAssetsand another one by_ResolveBlazorWasmOutputs.